Hedir Review : Support code modified / error ?

nlgw · Posted: Mon Mar 06, 2006 12:06 am Post subject: Support code modified / error ?

I just put up a page with the "Support code " but I had to modify the HTML code. Hope that's ok:

Copied from http://www.hedir.com/generate-suportcode.php was:
<img src='/styles/basic/img/hedir_approved.gif' border='0' alt=''>
changed to:
<img src='http://www.hedir.com/styles/basic/img/hedir_approved.gif' border='0' alt=''>

Now I get an JavaScript error on the page.
I'll look into it...

The page is here: http://www.sitelibrary.net/website/group/vote.html

----
I looked briefly at the JavaScript code and it could be that the line 35 has a problem. If I understand the code the function req.execute() may return without a value.

I havn't really debugged the code, let me know if it helps if I do the debug.

AjiNIMC · Joined: 11 Apr 2005 Posts: 516 18600 Hedir Points

I tried to vote but nothing happened.

nlgw · Posted: Mon Mar 06, 2006 1:38 am Post subject:

Thanks for the vote, AjiNIMC. Smile

I guess that (for the visitor) nothing happens is how it is implemented now.
Indeed I did not see what should happen in the code.
Maybe the .js should do a message "You've voted for the site" after the req.execute() in line 35.

AjiNIMC,
- what browser are you using ? Is Javascript enabled ?
- if IE do you have the Status bar visible ?
- if yes there's normally a blue "e" bottom left of the window.
Does that change to a yellow warning triangle ?
If yes there's some error with the page.
If you click it you'll get some more information.

baggeroli · Posted: Mon Mar 06, 2006 9:17 am Post subject:

Is this remote voting thingy anonymous? Shocked

nlgw · Posted: Mon Mar 06, 2006 9:37 am Post subject:

I think so, I tried it in a different browser that was not logged in and got no request to log in. But it isn't really really anonymous, of course: there's always the IP. And the proxy databases are not that bad - so the script could filter out most "real anonymous" votes, those surfers that use an anonymizer.